[#4071] Add metrics feature #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/metric-definitions
jtcohen6
reviewed
Nov 8, 2021
|
|
||
| metrics: | ||
|
|
||
| - model: people |
There was a problem hiding this comment.
Here and below, this should be:
Suggested change
| - model: people | |
| - model: ref('people') |
I had to use it to understand it :)
This was referenced Nov 8, 2021
jtcohen6
pushed a commit
that referenced
this pull request
Nov 9, 2021
* first cut at supporting metrics definitions * teach dbt about metrics * wip * support partial parsing for metrics * working on tests * Fix some tests * Add partial parsing metrics test * Fix some more tests * Update CHANGELOG.md * Fix partial parsing yaml file to correct model syntax Co-authored-by: Drew Banin <[email protected]>
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* first cut at supporting metrics definitions * teach dbt about metrics * wip * support partial parsing for metrics * working on tests * Fix some tests * Add partial parsing metrics test * Fix some more tests * Update CHANGELOG.md * Fix partial parsing yaml file to correct model syntax Co-authored-by: Drew Banin <[email protected]> automatic commit by git-black, original commits: 855419d
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* first cut at supporting metrics definitions * teach dbt about metrics * wip * support partial parsing for metrics * working on tests * Fix some tests * Add partial parsing metrics test * Fix some more tests * Update CHANGELOG.md * Fix partial parsing yaml file to correct model syntax Co-authored-by: Drew Banin <[email protected]> automatic commit by git-black, original commits: 31c88f9 6c6649f 726004b 855419d c69f28e d60f6bc
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* first cut at supporting metrics definitions * teach dbt about metrics * wip * support partial parsing for metrics * working on tests * Fix some tests * Add partial parsing metrics test * Fix some more tests * Update CHANGELOG.md * Fix partial parsing yaml file to correct model syntax Co-authored-by: Drew Banin <[email protected]> automatic commit by git-black, original commits: 2142e52 56ae206 855419d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4071
Description
This add the 'metrics' feature to dbt Core. See the ticket for more information.
Checklist
CHANGELOG.mdand added information about my change